Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add antimeridian support #62

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Add antimeridian support #62

merged 4 commits into from
Mar 18, 2022

Conversation

gadomski
Copy link
Contributor

@gadomski gadomski commented Mar 15, 2022 •
edited
Loading

Related Issue(s):

Description: Corrects antimeridian crossing issues with MODIS items. Configurable whether to split on -180 or 'normalize' so all longitudes are either positive or negative.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Example STAC Catalog has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@gadomski gadomski requested a review from pjhartzell March 15, 2022 15:24
pjhartzell
pjhartzell approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@pjhartzell pjhartzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gadomski
deps: pin stactools
2ad0fc9 
This is to pick up the antimeridian changes in a stable way.
@gadomski gadomski marked this pull request as ready for review March 18, 2022 17:44
@gadomski gadomski merged commit 477c06d into main Mar 18, 2022
@gadomski gadomski deleted the antimeridian branch March 18, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjhartzell pjhartzell pjhartzell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @pjhartzell